You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In PSY3, a time series' horizon was specified as a multiple of its resolution; in PSY4 it's its own TimePeriod. Within build_RTS_GMLC_RT_sys, the horizon of 24 was incorrectly migrated to 24 hours rather than to 24*(5 minute resolution) = 2 hours.
This may be my smallest ever pull request. Several hours of head scratching went into that one deleted character….
This was my bad...thanks for fixing. Did you look through the other cases already? If not, I can do that.
A brief search only revealed one other case in PSB where we were specifying the horizon manually this way and there the resolution happened to be an hour so it worked out. It'd be great if you could double-check.
This was my bad...thanks for fixing. Did you look through the other cases already? If not, I can do that.
A brief search only revealed one other case in PSB where we were specifying the horizon manually this way and there the resolution happened to be an hour so it worked out. It'd be great if you could double-check.
This was my bad...thanks for fixing. Did you look through the other cases already? If not, I can do that.
A brief search only revealed one other case in PSB where we were specifying the horizon manually this way and there the resolution happened to be an hour so it worked out. It'd be great if you could double-check.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In PSY3, a time series' horizon was specified as a multiple of its resolution; in PSY4 it's its own
TimePeriod. Withinbuild_RTS_GMLC_RT_sys, the horizon of 24 was incorrectly migrated to 24 hours rather than to 24*(5 minute resolution) = 2 hours.This may be my smallest ever pull request. Several hours of head scratching went into that one deleted character….